House cleaning of configurations by sanAkel · Pull Request #47 · GEOS-ESM/GEOS_OceanGridComp

sanAkel · 2023-10-04T15:56:41Z

This PR:

Gets rids of dysfunctional configurations (i.e., 360x210 and 360x320 resolutions).
Make use of WOA version 2018 (WOA18) as defaults, therefore no need to override via MOM_override.

To use these as defaults: ``` #override TIDEAMP_FILE = "tidal_amplitude.v20140616.nc_newtopo_config.nc" #override GEOTHERMAL_FILE = "geothermal_davies2013_v1_newtopo_config.nc" #override CHL_FILE = "seawifs-clim-1997-2010.1440x1080.v20180328_newtopo_config.nc" ```

This configuration **does not** work in GEOS applications, so get rid of it.

Use WOA version 18 initialize

Since WOA18 initialization works, make it default.

To make usage of WOA version 18 as default.

mathomp4 · 2023-10-04T16:59:32Z

The coupled tests are not happy. Do I need to change things at low res in my BCs set?

zhaobin74 · 2023-10-04T17:03:53Z

The coupled tests are not happy. Do I need to change things at low res in my BCs set?

Maybe because "woa18_decav_t01_04.nc" file is not present? It needs to be linked/copied in gcm_run.j.

mathomp4 · 2023-10-04T22:28:26Z

The coupled tests are not happy. Do I need to change things at low res in my BCs set?

Maybe because "woa18_decav_t01_04.nc" file is not present? It needs to be linked/copied in gcm_run.j.

Ah. Okay. I'm on leave until next week, so I'll try and get things fixed up then. @zhaobin74 where is this file located on discover so I can include it in TinyBCs?

@mathomp4 I saw your message and trying to fix it-- I have no idea where Yury kept the files I gave him. What he has in "oceanval" directory ( /home/yvikhlia/oceanval/verification/WOA18 ) is useless (because data in there goes to 1500 m only).

Just finished recreating the files and uploaded, but discover is having hiccups. Enjoy your break and see you week after.

sanAkel · 2023-10-04T23:21:34Z

@mathomp4, @zhaobin74 and all,

Please do following in your gcm_run.j (for now). Later, I'll coordinate with @biljanaorescanin to have these files populated in the BCs path .and. patch the App; see below(*).

set             FILE = linkbcs
/bin/rm -f     $FILE 
cat << _EOF_ > $FILE
#!/bin/csh -f
...
...
...

cp /discover/nobackup/sakella/woa18/1-deg/WOA18_decav_TPOTS_monthly_fulldepth_01.nc INPUT

 /bin/ln -sf $OBCSDIR/cice/kmt_cice.bin .
 /bin/ln -sf $OBCSDIR/cice/grid_cice.bin .

_EOF_

That gets a full_depth WOA18 T and S file into scratch/INPUT.

(*) Reason for not patching the App at this moment is so as to get @biljanaorescanin's help (as needed) in order to copy files from ⬆️ path and purge whats not needed.

I can successfully run with my WOA18_decav_TPOTS_monthly_fulldepth_01.nc, so I expect you can as well.

@zhaobin74 For the 540x458 configuration you are using, I assume you are using woa18_04_initial_conditions.nc in which case, you can copy from /discover/nobackup/sakella/MOM6-GFDL/MOM6-testing/Gustavo.Marques/datasets/woa18_04_initial_conditions.nc

@sanAkel

Use @sanAkel's version of **full depth** WOA18 T and S file.

@sanAkel

Use @sanAkel's WOA18 T and S file

mathomp4 · 2023-10-10T11:36:01Z

@sanAkel I can't see the file (rw only for you), but... 900MB. Ouch.

Maybe once I can see inside it, I can work with you to prune it down for TinyBCs (i.e., if it's a daily file or something, we can pull out just a few days).

sanAkel · 2023-10-10T11:41:48Z

~~That (cut size) can be done. See in about an hour.~~ Needs to be trimmed a lot!

sanAkel · 2023-10-31T14:31:45Z

@mathomp4 I have undrafted this PR (again)! I don't want to hold off this clean up anymore (until I get a coarser WOA initial conditions. When we spoke last week, you said that the file size is ok.)

@zhaobin74 can you please review this PR.

Thanks!

mathomp4 · 2023-10-31T18:27:01Z

Yay it's working!

mathomp4 · 2023-10-31T19:14:07Z

Yay it worked! :)

zhaobin74 · 2023-10-31T19:35:40Z

Yay it worked! :)
@mathomp4, you mean it worked for c12x5 setup, right?

mathomp4 · 2023-11-01T13:52:35Z

Yay it worked! :)
@mathomp4, you mean it worked for c12x5 setup, right?

Yes. Mainly that the CI didn't crash like before. The ocean could be boiling for all I know, but it ran for 6 hours! 😄

zhaobin74 · 2023-11-01T15:18:11Z

Yay it worked! :)
@mathomp4, you mean it worked for c12x5 setup, right?

Yes. Mainly that the CI didn't crash like before. The ocean could be boiling for all I know, but it ran for 6 hours! 😄

Thanks, @mathomp4. I can test the other two configs, 1440x1080 and 540x458.

zhaobin74 · 2023-11-01T15:20:40Z

First, 1440x1080 didn't work out of the box.

cp /discover/nobackup/sakella/woa18/1-deg/WOA18_decav_TPOTS_monthly_fulldepth_01.nc INPUT

failed with permission denied error.

I see there is another (smaller) file /discover/nobackup/sakella/woa18/1-deg/WOA18_decav_TPOTS_mon01_fulldepth_01.nc. Using this file worked.

Is this one supposed to be used? In that case, 1440x1080/MOM_input should be updated to this new file.

zhaobin74 · 2023-11-01T16:18:18Z

540x458 config works out of the box with /discover/nobackup/sakella/MOM6-GFDL/MOM6-testing/Gustavo.Marques/datasets/woa18_04_initial_conditions.nc

sanAkel · 2023-11-02T17:08:38Z

/discover/nobackup/sakella/woa18/1-deg/WOA18_decav_TPOTS_monthly_fulldepth_01.nc

@zhaobin74 thanks for testing both configurations:

1440x1080 I fixed the file permission issue. Sorry, somehow I overlooked it! Whenever I scp files from local mac ➡️ discover, this happens.

-rw-r--r-- 1 sakella s2640 908M Oct 4 18:24 /discover/nobackup/sakella/woa18/1-deg/WOA18_decav_TPOTS_monthly_fulldepth_01.nc

Reg:

I see there is another (smaller) file /discover/nobackup/sakella/woa18/1-deg/WOA18_decav_TPOTS_mon01_fulldepth_01.nc. Using this file worked.
Is this one supposed to be used?

NO. I want to use for this coarse- resolution tests only.

In that case, 1440x1080/MOM_input should be updated to this new file.

⬆️ Not needed since I fixed the file permissions.

540x458

config works out of the box
👍 Thanks!

sanAkel · 2023-11-02T17:09:38Z

@zhaobin74 can You please retry 1440x1080?

sanAkel · 2023-11-02T17:10:16Z

@mathomp4 can you approve the PR since it seems to have worked for you.

mathomp4 · 2023-11-02T17:19:25Z

@mathomp4 can you approve the PR since it seems to have worked for you.

Approved. Though without Yury, once @zhaobin74 approves I might have to use superpowers to get it in.

zhaobin74 · 2023-11-02T18:33:10Z

@zhaobin74 can You please retry 1440x1080?

After the permission fix, 1440x1080 config is working:smiley:

sanAkel · 2023-11-02T19:02:19Z

@mathomp4 can you approve the PR since it seems to have worked for you.

Approved. Though without Yury, once @zhaobin74 approves I might have to use superpowers to get it in.

Yes @mathomp4 please use them! 😄

House cleaning of configurations

sanAkel added 6 commits October 4, 2023 11:16

Update MOM_input

defefaf

To use these as defaults: ``` #override TIDEAMP_FILE = "tidal_amplitude.v20140616.nc_newtopo_config.nc" #override GEOTHERMAL_FILE = "geothermal_davies2013_v1_newtopo_config.nc" #override CHL_FILE = "seawifs-clim-1997-2010.1440x1080.v20180328_newtopo_config.nc" ```

Delete MOM6_GEOSPlug/mom6_app/360x320 directory

20d5932

This configuration **does not** work in GEOS applications, so get rid of it.

Delete MOM6_GEOSPlug/mom6_app/360x210 directory

1334428

This configuration **does not** work in GEOS applications, so get rid of it.

Update MOM_input

dce39f7

Use WOA version 18 initialize

Update MOM_override

bf2ccee

Since WOA18 initialization works, make it default.

Update MOM_input

6bf126d

To make usage of WOA version 18 as default.

sanAkel added the 0 diff structural Structural changes to repository that are zero-diff label Oct 4, 2023

sanAkel requested review from mathomp4 and zhaobin74 October 4, 2023 15:56

sanAkel requested a review from a team as a code owner October 4, 2023 15:56

sanAkel self-assigned this Oct 4, 2023

sanAkel marked this pull request as draft October 4, 2023 22:46

sanAkel marked this pull request as ready for review October 4, 2023 23:21

sanAkel added 4 commits October 4, 2023 19:24

Update MOM_input

c3b821e

Use @sanAkel's version of **full depth** WOA18 T and S file.

Update MOM_input

5716c3b

Use @sanAkel's WOA18 T and S file

Merge branch 'develop' into sanAkel-patch-1

d80fe54

Merge branch 'develop' into sanAkel-patch-1

fb9ee73

sanAkel marked this pull request as draft October 11, 2023 15:16

Merge branch 'develop' into sanAkel-patch-1

eb6540f

sanAkel marked this pull request as ready for review October 31, 2023 14:29

Trivial commit to re-trigger CI

aa34d36

This was referenced Oct 31, 2023

Update CI BCs to v11.3.0 GEOS-ESM/GEOSgcm#693

Merged

Routine maintenance/update #49

Merged

mathomp4 approved these changes Nov 2, 2023

View reviewed changes

zhaobin74 approved these changes Nov 2, 2023

View reviewed changes

mathomp4 merged commit a649d4d into develop Nov 2, 2023

mathomp4 deleted the sanAkel-patch-1 branch November 2, 2023 19:04

sinakhani pushed a commit that referenced this pull request Jul 14, 2025

Merge pull request #47 from GEOS-ESM/sanAkel-patch-1

4ccd862

House cleaning of configurations

Conversation

sanAkel commented Oct 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mathomp4 commented Oct 4, 2023

Uh oh!

zhaobin74 commented Oct 4, 2023

Uh oh!

mathomp4 commented Oct 4, 2023 • edited by sanAkel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sanAkel commented Oct 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mathomp4 commented Oct 10, 2023

Uh oh!

sanAkel commented Oct 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sanAkel commented Oct 31, 2023

Uh oh!

mathomp4 commented Oct 31, 2023

Uh oh!

mathomp4 commented Oct 31, 2023

Uh oh!

zhaobin74 commented Oct 31, 2023

Uh oh!

mathomp4 commented Nov 1, 2023

Uh oh!

zhaobin74 commented Nov 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhaobin74 commented Nov 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhaobin74 commented Nov 1, 2023

Uh oh!

sanAkel commented Nov 2, 2023

Uh oh!

sanAkel commented Nov 2, 2023

Uh oh!

sanAkel commented Nov 2, 2023

Uh oh!

mathomp4 commented Nov 2, 2023

Uh oh!

zhaobin74 commented Nov 2, 2023

Uh oh!

sanAkel commented Nov 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sanAkel commented Oct 4, 2023 •

edited

Loading

mathomp4 commented Oct 4, 2023 •

edited by sanAkel

Loading

sanAkel commented Oct 4, 2023 •

edited

Loading

sanAkel commented Oct 10, 2023 •

edited

Loading

zhaobin74 commented Nov 1, 2023 •

edited

Loading

zhaobin74 commented Nov 1, 2023 •

edited

Loading