Skip to content

docs: [12-FE] Blog #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 7, 2023
Merged

docs: [12-FE] Blog #254

merged 4 commits into from
Feb 7, 2023

Conversation

@poiu694
Copy link

@poiu694 poiu694 commented Dec 17, 2022

.

@hoqn hoqn added the 🙋‍♂️🙋‍♀️ 리뷰 요청 PR 리뷰를 요청합니다~ label Dec 21, 2022
pasly0920
pasly0920 reviewed Dec 28, 2022
View reviewed changes
_posts/2022-12-18-task.md Outdated
Comment on lines 15 to 17
Copy link
Member

@pasly0920 pasly0920 Dec 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 부분에 마이크로 태스크 큐에 대해서도 간단하게 언급이 있으면 좋을 것 같아요. 콜 스택과, 태스크 큐 뒤에 갑작스럽게 마이크로 태스크 큐가 등장하는 것 같아요.

Copy link
Author

@poiu694 poiu694 Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cea3af2 반영했숨니당 ㅎㅎㅎ

pasly0920
pasly0920 reviewed Dec 28, 2022
View reviewed changes
Copy link
Member

@pasly0920 pasly0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맨 마지막 부분에 전체 글을 간단하게 요약해주는 그림이나 글이 있으면 더 보기 좋을 것 같습니다.

@poiu694
Copy link
Author

poiu694 commented Jan 6, 2023

맨 마지막 부분에 전체 글을 간단하게 요약해주는 그림이나 글이 있으면 더 보기 좋을 것 같습니다.

3460413 반영했습니당 ! 기존 이미지를 요약 그림으로, 표지를 ㅅ ㅐ로 가져왔어용

pasly0920
pasly0920 approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@pasly0920 pasly0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SSUHYUNKIM
Copy link

SSUHYUNKIM commented Jan 9, 2023

image

혹시 의도랑 다르게 반영된 부분있는지 확인해주시고 추가 수정 사항 없으면 아래에 수정 사항 없다고 남겨주세요!

@SSUHYUNKIM SSUHYUNKIM added ✅ 리뷰 완료 한 명 이상이 리뷰를 완료했을 때 🔨 수정 요청 리뷰 과정 중 수정 사항이 생겼을 때 and removed 🙋‍♂️🙋‍♀️ 리뷰 요청 PR 리뷰를 요청합니다~ labels Jan 9, 2023
@poiu694
Copy link
Author

poiu694 commented Jan 9, 2023

수정사항 없습니당 !

custardcream98
custardcream98 approved these changes Jan 9, 2023
View reviewed changes
Copy link

@custardcream98 custardcream98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

토막상식같은 느낌으로 잘 봤습니다 감사합니당!!

@SSUHYUNKIM SSUHYUNKIM added 💯 최종 완료 모든 수정과 리뷰가 끝난 후 merge를 기다릴 때 and removed ✅ 리뷰 완료 한 명 이상이 리뷰를 완료했을 때 🔨 수정 요청 리뷰 과정 중 수정 사항이 생겼을 때 labels Jan 10, 2023
@SSUHYUNKIM SSUHYUNKIM requested review from SSUHYUNKIM and removed request for baebae02 and dlalsrb0248 February 7, 2023 10:48
@SSUHYUNKIM SSUHYUNKIM merged commit d6469b1 into GDSC-University-of-Seoul:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SSUHYUNKIM SSUHYUNKIM SSUHYUNKIM approved these changes

+2 more reviewers

@pasly0920 pasly0920 pasly0920 approved these changes

@custardcream98 custardcream98 custardcream98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@poiu694 poiu694

Labels

💯 최종 완료 모든 수정과 리뷰가 끝난 후 merge를 기다릴 때

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@poiu694 @SSUHYUNKIM @pasly0920 @custardcream98 @hoqn