Rust/gscan #639
Open
Rust/gscan #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Line endings were CRLF. Diff is not really usable. |
GermanCoding
requested changes
Oct 29, 2024
| help = "List of urls to scan separated by whitepace" | ||
| )] | ||
| urls: Vec<Url>, | ||
| } |
There was a problem hiding this comment.
Let's consider adding args for VAAS_URL and TOKEN_URL so that non-prod envs can be used in the example.
|
|
||
| fn expand_entry(p: &PathBuf) -> Box<dyn Iterator<Item = PathBuf>> { | ||
| if p.is_file() { | ||
| return Box::new(std::iter::once(p.clone())); |
There was a problem hiding this comment.
NIT: We can avoid the clone here by taking ownership of the PathBuf in the function signature. This also makes sense syntactically.
| .into_iter() | ||
| .filter_map(|e| e.ok()) | ||
| .filter(|e| e.file_type().is_file()) | ||
| .map(|e| e.path().to_path_buf()); |
There was a problem hiding this comment.
Suggested change
| .map(|e| e.path().to_path_buf()); | |
| .map(|e| e.into_path()); |
Simpler + avoids a clone
| async fn scan_urls( | ||
| urls: &[Url], | ||
| vaas_connection: &Connection, | ||
| ) -> VResult<HashMap<Url, Result<VaasVerdict, vaas::error::Error>>> { |
There was a problem hiding this comment.
Suggested change
| ) -> VResult<HashMap<Url, Result<VaasVerdict, vaas::error::Error>>> { | |
| ) -> HashMap<Url, VResult<VaasVerdict>> { |
| verdicts.insert(url.to_owned(), verdict); | ||
| } | ||
|
|
||
| Ok(verdicts) |
There was a problem hiding this comment.
Suggested change
| Ok(verdicts) | |
| verdicts |
| print_verdicts(p.display().to_string(), &verdict); | ||
| }).await; | ||
|
|
||
| let url_verdicts = scan_urls(args.urls.as_ref(), &vaas_connection).await?; |
There was a problem hiding this comment.
Suggested change
| let url_verdicts = scan_urls(args.urls.as_ref(), &vaas_connection).await?; | |
| let url_verdicts = scan_urls(args.urls.as_ref(), &vaas_connection).await; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs (-f, -u)
Concurrent scans
Iterate over directories