Phpdev async with amphp #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also replaces this #544 |
|
You can see the asnyc version running in this GDATASoftwareAG/nextcloud-gdata-antivirus#117 |
unglaublicherdude
requested review from
doxthree,
pstadermann,
GermanCoding and
lennartdohmann
|
This has to be a major release because there is a big api change |
Closed
doxthree
reviewed
Sep 6, 2024
pstadermann
approved these changes
Sep 6, 2024
|
will merge this, after the wordpress-review is passed |
…so the loop isn't running beyond the lifetime of the VaasConnection
…active connection
Co-authored-by: doxthree <[email protected]>
unglaublicherdude
force-pushed
the
phpdev-async-with-amphp
branch
from
35a3bf3
to
2ae6a9c
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So basically you can now require a specific branch.
Branches that are named like phpdev-* are pushed without the phpdev- prefix to the vaas-php repository.
So when you have a branch called phpdev-somethinggreat you can install the branch with