Reduce number of activity events generated by tags #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new SystemTagObjectMapperWithoutActivity that uses a dummy event system to avoid triggering activities. Change TagService so that callers can decide if they want activities generated for the tags or not. Change defaults to only trigger activities for Malicious + Pup tags. This still generates some events for the initial creation of the system tags (done on first use), which is acceptable I think (it's only like 5 events). Add a new test for the new behaviour.
GermanCoding
requested review from
pstadermann,
unglaublicherdude,
doxthree and
lennartdohmann
pstadermann
approved these changes
Sep 3, 2024
GermanCoding
added a commit
that referenced
this pull request
Sep 3, 2024
This introduces a new SystemTagObjectMapperWithoutActivity that uses a dummy event system to avoid triggering activities. Change TagService so that callers can decide if they want activities generated for the tags or not. Change defaults to only trigger activities for Malicious + Pup tags. This still generates some events for the initial creation of the system tags (done on first use), which is acceptable I think (it's only like 5 events). Add a new test for the new behaviour.
unglaublicherdude
pushed a commit
that referenced
this pull request
Sep 9, 2024
This introduces a new SystemTagObjectMapperWithoutActivity that uses a dummy event system to avoid triggering activities. Change TagService so that callers can decide if they want activities generated for the tags or not. Change defaults to only trigger activities for Malicious + Pup tags. This still generates some events for the initial creation of the system tags (done on first use), which is acceptable I think (it's only like 5 events). Add a new test for the new behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new SystemTagObjectMapperWithoutActivity that uses a dummy event dispatcher to avoid triggering activities.
Change TagService so that callers can decide if they want activities generated for the tags or not. Change defaults to only trigger activities for Malicious + Pup tags.
This still generates some events for the initial creation of the system tags (done on first use), which is acceptable I think (it's only like 5 events).
Add a new test for the new behaviour.
[Please squash on merge]