Skip to content
This repository was archived by the owner on Mar 16, 2021. It is now read-only.

Feature: restrict TiFragment api for subclasses #79

Merged
merged 5 commits into from
Apr 5, 2017
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import net.grandcentrix.thirtyinch.util.AnnotationUtil;

import android.os.Bundle;
import android.support.annotation.CallSuper;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.support.v4.app.Fragment;
Expand All @@ -53,19 +54,19 @@ public abstract class TiFragment<P extends TiPresenter<V>, V extends TiView> ext

@NonNull
@Override
public Removable addBindViewInterceptor(@NonNull final BindViewInterceptor interceptor) {
public final Removable addBindViewInterceptor(@NonNull final BindViewInterceptor interceptor) {
return mDelegate.addBindViewInterceptor(interceptor);
}

@Nullable
@Override
public V getInterceptedViewOf(@NonNull final BindViewInterceptor interceptor) {
public final V getInterceptedViewOf(@NonNull final BindViewInterceptor interceptor) {
return mDelegate.getInterceptedViewOf(interceptor);
}

@NonNull
@Override
public List<BindViewInterceptor> getInterceptors(
public final List<BindViewInterceptor> getInterceptors(
@NonNull final Filter<BindViewInterceptor> predicate) {
return mDelegate.getInterceptors(predicate);
}
Expand All @@ -79,12 +80,12 @@ public String getLoggingTag() {
* is {@code null} before {@link #onCreate(Bundle)}
*/
@Override
public P getPresenter() {
public final P getPresenter() {
return mDelegate.getPresenter();
}

@Override
public Executor getUiThreadExecutor() {
public final Executor getUiThreadExecutor() {
return mUiThreadExecutor;
}

Expand All @@ -93,41 +94,43 @@ public Executor getUiThreadExecutor() {
* through all the interceptors (again).
*/
@Override
public void invalidateView() {
public final void invalidateView() {
mDelegate.invalidateView();
}

@Override
public boolean isDontKeepActivitiesEnabled() {
public final boolean isDontKeepActivitiesEnabled() {
return AndroidDeveloperOptions.isDontKeepActivitiesEnabled(getActivity());
}

@Override
public boolean isFragmentAdded() {
public final boolean isFragmentAdded() {
return isAdded();
}

@Override
public boolean isFragmentDetached() {
public final boolean isFragmentDetached() {
return isDetached();
}

@Override
public boolean isHostingActivityChangingConfigurations() {
public final boolean isHostingActivityChangingConfigurations() {
return getActivity().isChangingConfigurations();
}

@Override
public boolean isHostingActivityFinishing() {
public final boolean isHostingActivityFinishing() {
return getActivity().isFinishing();
}

@CallSuper
@Override
public void onCreate(final Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
mDelegate.onCreate_afterSuper(savedInstanceState);
}

@CallSuper
@Nullable
@Override
public View onCreateView(final LayoutInflater inflater, @Nullable final ViewGroup container,
Expand All @@ -136,30 +139,35 @@ public View onCreateView(final LayoutInflater inflater, @Nullable final ViewGrou
return super.onCreateView(inflater, container, savedInstanceState);
}

@CallSuper
@Override
public void onDestroy() {
super.onDestroy();
mDelegate.onDestroy_afterSuper();
}

@CallSuper
@Override
public void onDestroyView() {
mDelegate.onDestroyView_beforeSuper();
super.onDestroyView();
}

@CallSuper
@Override
public void onSaveInstanceState(final Bundle outState) {
super.onSaveInstanceState(outState);
mDelegate.onSaveInstanceState_afterSuper(outState);
}

@CallSuper
@Override
public void onStart() {
super.onStart();
mDelegate.onStart_afterSuper();
}

@CallSuper
@Override
public void onStop() {
mDelegate.onStop_beforeSuper();
Expand Down Expand Up @@ -196,7 +204,7 @@ public V provideView() {
}

@Override
public void setFragmentRetainInstance(final boolean retain) {
public final void setFragmentRetainInstance(final boolean retain) {
setRetainInstance(retain);
}

Expand Down