Add TiDialogFragment

[remcomokveld]

Speaks for itself. Although I can think of prettier, delegate based, solutions to add MVP support for DialogFragments this is a simple copy from TiFragment but it extends android.support.v4.app.DialogFragment instead of android.support.v4.app.Fragment

[passsy]

please have a look at this @lacky1991

[StefMa]

Don't know if i like the idea.
Have you really so much business logic inside your Dialog? 🤔
However. If we do it, then we need to use a Delegate and merge all the duplicated code from TiFragment and TiDialogFragment...

[passsy]

Yes, a delegate is definitely required. This is also required when we want to support TiFragment and TiDialogFragment for the plugin.
As a first step I'm ok with the duplicated code. But I remember @lacky1991 found a edge case when he implemented TiDialogFragment himself.

[remcomokveld]

If I have a dialog where I can edit a data object and what to save/sync this changes, I need to have a tested presenter which does that business logic. Totally agree with the fact that it should be implemented with a delegate

[StefMa]

@remcomokveld are you still working on it?
It seems that more people needs the DialogFragment than I thought 😃

[Nxt3]

I noticed that while using this the layout of my Dialog gets wonky. If I extend AppCompatDialogFragment instead of TiDialogFragment--the layout is fine. Not sure what the cause could be.

Here is the layout for my dialog

Correct (extending AppCompatDialogFragment)

Incorrect (extending TiDialogFragment)

[passsy]

Looks fine for me with the TiDialogFragment extends DialogFragment.

And I can't imagine the code of TiDialogFragment causes this. My best guess is some caching bug of instant run 😉

[Nxt3]

I don't use instant run. It seems to be the difference of extending "DialogFragment" vs "AppCompatDialogFragment"

[passsy]

Now I got it! Yes the TiDialogFragment should extend AppCompatDialogFragment and not DialogFragment.

I think this here causes the difference:

    // AppCompatDialogFragment
    @Override
    public Dialog onCreateDialog(Bundle savedInstanceState) {
        return new AppCompatDialog(getContext(), getTheme());
    }

    // DialogFragment
    public Dialog onCreateDialog(Bundle savedInstanceState) {
        return new Dialog(getActivity(), getTheme());
    }

AppCompatDialogFragment also hints:

A special version of {@link DialogFragment} which uses an {@link AppCompatDialog} in place of a platform-styled dialog.

[passsy]

should extend AppCompatDialogFragment instead of DialogFragment

[StefMa]

[StefMa]

It seems @remcomokveld don't maintain this anymore.
I've just created another PR with the AppCompat fix. See #42.

This will be closed.