Fix dynamic select fields (#50)

G4brym · Aug 1, 2024 · ea038a5 · ea038a5
1 parent 58e7323
commit ea038a5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "workers-qb",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "Zero dependencies Query Builder for Cloudflare Workers",
   "main": "./dist/index.js",
   "module": "./dist/index.mjs",

diff --git a/src/modularBuilder.ts b/src/modularBuilder.ts
@@ -101,6 +101,8 @@ export class SelectBuilder<GenericResultWrapper, GenericResult = DefaultReturnOb
     let val = []
     if (!Array.isArray(value)) {
       val.push(value)
+    } else {
+      val = value
     }
 
     if (option && Array.isArray(option)) {

diff --git a/tests/builder/select.test.ts b/tests/builder/select.test.ts
@@ -190,7 +190,7 @@ describe('Select Builder', () => {
     for (const result of [
       new QuerybuilderTest().fetchAll({
         tableName: 'testTable',
-        fields: '*',
+        fields: ['id', 'name'],
         where: {
           conditions: 'field = ?1',
           params: ['test'],
@@ -203,13 +203,13 @@ describe('Select Builder', () => {
       }),
       new QuerybuilderTest()
         .select('testTable')
-        .fields('*')
+        .fields(['id', 'name'])
         .where('field = ?1', 'test')
         .join({ type: JoinTypes.LEFT, table: 'employees', on: 'testTable.employee_id = employees.id' })
         .getQuery(),
     ]) {
       expect(trimQuery(result.query)).toEqual(
-        'SELECT * FROM testTable LEFT JOIN employees ON testTable.employee_id = employees.id WHERE field = ?1'
+        'SELECT id, name FROM testTable LEFT JOIN employees ON testTable.employee_id = employees.id WHERE field = ?1'
       )
       expect(result.arguments).toEqual(['test'])
       expect(result.fetchType).toEqual('ALL')