Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSONB instead of JSON for context object in SQLite. #871

Merged
merged 15 commits into from
Feb 7, 2024
Merged

Use JSONB instead of JSON for context object in SQLite. #871

merged 15 commits into from
Feb 7, 2024

Conversation

dsuhinin
Copy link
Collaborator

@dsuhinin dsuhinin commented Feb 7, 2024 •
edited
Loading

What's inside the box:

  • migrate context datatype from json -> jsonb for sqlite.
  • simplify and adopt integration tests.

@dsuhinin dsuhinin linked an issue Feb 7, 2024 that may be closed by this pull request
Metrics context: use JSONB in SQLite #851
Closed
suprjinx
suprjinx approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dsuhinin dsuhinin merged commit 0bda8b4 into G-Research:main Feb 7, 2024
17 checks passed
@dsuhinin dsuhinin deleted the dsuhinin/migration-from-json-to-jsonb branch February 7, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suprjinx suprjinx suprjinx approved these changes

@jgiannuzzi jgiannuzzi Awaiting requested review from jgiannuzzi

@fabiovincenzi fabiovincenzi Awaiting requested review from fabiovincenzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics context: use JSONB in SQLite
2 participants
@dsuhinin @suprjinx