Skip to content

Improvements for /metrics/get-history endpoint. #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 23, 2024
Merged

Improvements for /metrics/get-history endpoint. #815

merged 5 commits into from
Jan 23, 2024

Conversation

dsuhinin
Copy link
Collaborator

What's inside the box:

  • use Joins instead of Preload to immediately load all the data and do not call database for each context record.
  • when we format response object, optimise working process with context object.

@dsuhinin dsuhinin linked an issue Jan 22, 2024 that may be closed by this pull request
Optimize MetricHistory endpoint #661
Closed
suprjinx
suprjinx previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsuhinin dsuhinin merged commit 943662a into G-Research:main Jan 23, 2024
@dsuhinin dsuhinin deleted the dsuhinin/metric-history-endpoint-optimizatons branch January 23, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suprjinx suprjinx suprjinx approved these changes

@fabiovincenzi fabiovincenzi Awaiting requested review from fabiovincenzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize MetricHistory endpoint
2 participants
@dsuhinin @suprjinx