Context query subscript #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultContext.ID during migration
dictionary has become)
jgiannuzzi
reviewed
Jan 15, 2024
dsuhinin
reviewed
Jan 22, 2024
pkg/api/aim/query/query.go
Outdated
| func (pq *parsedQuery) Filter(tx *gorm.DB) *gorm.DB { | ||
| for _, j := range pq.joins { | ||
| for _, k := range pq.joinKeys { | ||
| j := pq.joins[k] |
There was a problem hiding this comment.
could it be circumstance, when j := pq.joins[k] is nil?
There was a problem hiding this comment.
i searched for all cases where we append to pq.joins to make sure this isn't possible (using pq.AddJoin ensures this). Added some error-level logging if joins[k] is nil.
dsuhinin
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ability to use aim "context subscript" query eg "runs.metrics["metricname", {'key': 'value1'}]"
fixes #360