Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent deletion of default namespace and default experiment #778

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Prevent deletion of default namespace and default experiment #778

merged 5 commits into from
Jan 2, 2024

Conversation

dsuhinin
Copy link
Collaborator

@dsuhinin dsuhinin commented Dec 28, 2023 •
edited
Loading

PR 1/2. What's inside the box:

  • prevent deletion for default namespace.
  • prevent deletion for default experiment.
  • fix typos.
  • updated unit and integration tests according to the new logic.

@dsuhinin dsuhinin requested review from fabiovincenzi, suprjinx and jgiannuzzi and removed request for fabiovincenzi and suprjinx December 28, 2023 16:40
@dsuhinin dsuhinin linked an issue Dec 28, 2023 that may be closed by this pull request
prevent deletion of default namespace and default experiment #727
Closed
@dsuhinin dsuhinin added the enhancement New feature or request label Dec 29, 2023
suprjinx
suprjinx approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@dsuhinin dsuhinin merged commit 577d996 into G-Research:main Jan 2, 2024
17 checks passed
@dsuhinin dsuhinin deleted the dsuhinin/prevent-deletion-default-entities branch January 2, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suprjinx suprjinx suprjinx approved these changes

@jgiannuzzi jgiannuzzi Awaiting requested review from jgiannuzzi

@fabiovincenzi fabiovincenzi Awaiting requested review from fabiovincenzi

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prevent deletion of default namespace and default experiment
2 participants
@dsuhinin @suprjinx