Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Random Forest Example #700

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

Sharpz7
Copy link
Contributor

@Sharpz7 Sharpz7 commented Dec 7, 2023

Fixes #699

@suprjinx
Copy link
Contributor

suprjinx commented Dec 7, 2023

LGTM -- afaik this example was not working since it lacked the required csv files

suprjinx
suprjinx previously approved these changes Dec 7, 2023
@Sharpz7
Copy link
Contributor Author

Sharpz7 commented Dec 8, 2023

@suprjinx The idea was you would download them. They were quite large so I avoided putting them in originally. This example is more complete and more relevant anyways so makes sense to include.

@jgiannuzzi jgiannuzzi changed the title Removed Random Forrest Example Removed Random Forest Example Dec 8, 2023
Copy link
Member

@jgiannuzzi jgiannuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also remove the poetry dependencies that are not needed anymore?

dave-gantenbein
dave-gantenbein previously approved these changes Dec 8, 2023
Copy link

@dave-gantenbein dave-gantenbein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@jgiannuzzi jgiannuzzi dismissed stale reviews from dave-gantenbein and suprjinx December 8, 2023 11:49

dependencies need to be updated first

@jgiannuzzi jgiannuzzi merged commit 2d7a1ec into G-Research:main Dec 11, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Random Forest Example
4 participants