Enable metric.context filter in Aim metrics search #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
select from metrics
suprjinx
changed the title
suprjinx
changed the title
suprjinx
commented
Dec 7, 2023
| } | ||
|
|
||
| func (eq JsonEq) Build(builder clause.Builder) { | ||
| eq.Left.Build(builder) |
There was a problem hiding this comment.
i had to "override" these methods from the Gorm built-in so we could call Build on the left-hand portion, instead of writing quoted
…kml into json-context-query-aim
@fabiovincenzi I am not able to reproduce -- the filtering works correctly for me. Screenshots: |
fabiovincenzi
approved these changes
Dec 18, 2023
| { | ||
| name: "SearchMetricContext", | ||
| request: request.SearchMetricsRequest{ | ||
| Query: `metric.name == "TestMetric1" and metric.context.testkey == "testvalue"`, |
There was a problem hiding this comment.
Maybe using multiple metric.name in the query to see if different metrics are filtered by context, something like:
Query: ((metric.name == "TestMetric1") or (metric.name == "TestMetric2")) and metric.context.testkey == "testvalue"
| { | ||
| name: "NegativeSearchMetricContext", | ||
| request: request.SearchMetricsRequest{ | ||
| Query: `metric.name == "TestMetric1" and metric.context.testkey != "testvalue"`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ths PR adapts the query parser used by the Aim api to accept
metric.contextfiltersFixes #361