Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the output of the hidden decode command #648

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Improve the output of the hidden decode command #648

merged 1 commit into from
Nov 27, 2023

Conversation

dsuhinin
Copy link
Collaborator

@dsuhinin dsuhinin commented Nov 27, 2023 •
edited by jgiannuzzi
Loading

What's inside the box:

  • stream decode command output now formatted.

Fixes #515.

@dsuhinin dsuhinin linked an issue Nov 27, 2023 that may be closed by this pull request
The hidden decode command's output has become unreadable #515
Closed
@dsuhinin dsuhinin changed the title Fix stream data decoder output. Fix hidden decode command's output. Nov 27, 2023
@dsuhinin dsuhinin changed the title Fix hidden decode command's output. Fix hidden stream decode command's output. Nov 27, 2023
jgiannuzzi
jgiannuzzi approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@jgiannuzzi jgiannuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to make it stream, like the original implementation (here it's still decoding everything before anything gets printed), but this is already a great usability improvement!

@jgiannuzzi jgiannuzzi changed the title Fix hidden stream decode command's output. Improve the output of the hidden decode command Nov 27, 2023
@jgiannuzzi jgiannuzzi removed a link to an issue Nov 27, 2023
The hidden decode command's output has become unreadable #515
Closed
@jgiannuzzi jgiannuzzi linked an issue Nov 27, 2023 that may be closed by this pull request
The hidden decode command's output has become unreadable #515
Closed
@dsuhinin dsuhinin merged commit 9675930 into G-Research:main Nov 27, 2023
17 checks passed
@dsuhinin dsuhinin deleted the dsuhinin/fix-stream-decoder-output branch November 27, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgiannuzzi jgiannuzzi jgiannuzzi approved these changes

@suprjinx suprjinx Awaiting requested review from suprjinx

@fabiovincenzi fabiovincenzi Awaiting requested review from fabiovincenzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The hidden decode command's output has become unreadable
2 participants
@dsuhinin @jgiannuzzi