Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test suite setup/teardown #645

Merged
merged 6 commits into from
Nov 24, 2023

Conversation

jgiannuzzi
Copy link
Member

@jgiannuzzi jgiannuzzi commented Nov 23, 2023

This PR is a big refactor of the way we setup our integration tests. It aims at reducing some of the boilerplate we have in each test suite. I would recommend reviewing by looking at the 4 commits individually.

@jgiannuzzi jgiannuzzi self-assigned this Nov 23, 2023
dsuhinin
dsuhinin previously approved these changes Nov 23, 2023
Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! That's huge improvement.

tests/integration/golang/helpers/test.go Outdated Show resolved Hide resolved
tests/integration/golang/helpers/test.go Outdated Show resolved Hide resolved
tests/integration/golang/mlflow/run/log_metric_test.go Outdated Show resolved Hide resolved
tests/integration/golang/mlflow/run/log_metric_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jgiannuzzi jgiannuzzi merged commit fdfbb96 into G-Research:main Nov 24, 2023
17 checks passed
@jgiannuzzi jgiannuzzi deleted the setup-tests branch November 24, 2023 08:13
@jgiannuzzi
Copy link
Member Author

Part of the work for #561.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants