Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous improvements to integration tests #644

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Miscellaneous improvements to integration tests #644

merged 1 commit into from
Nov 23, 2023

Conversation

jgiannuzzi
Copy link
Member

This PR is a grab bag of little fixes/improvements to the integration tests:

  • some responses were not correctly validated
  • some errors were checked twice
  • some typos in test names and comments
  • some inconsistent formatting

@jgiannuzzi jgiannuzzi self-assigned this Nov 23, 2023
dsuhinin
dsuhinin approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jgiannuzzi jgiannuzzi merged commit 1d5df11 into G-Research:main Nov 23, 2023
17 checks passed
@jgiannuzzi jgiannuzzi deleted the grab-bag branch November 23, 2023 16:50
@jgiannuzzi jgiannuzzi linked an issue Nov 24, 2023 that may be closed by this pull request
Integration tests: add a new way to run them against a new separate server instance per test #561
Closed
23 tasks
@jgiannuzzi
Copy link
Member Author

Part of the work for #561.

@jgiannuzzi jgiannuzzi mentioned this pull request Nov 24, 2023
Closed
23 tasks
@jgiannuzzi jgiannuzzi removed a link to an issue Nov 24, 2023
Integration tests: add a new way to run them against a new separate server instance per test #561
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiovincenzi fabiovincenzi fabiovincenzi approved these changes

@dsuhinin dsuhinin dsuhinin approved these changes

Assignees

@jgiannuzzi jgiannuzzi

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgiannuzzi @dsuhinin @fabiovincenzi