Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup experiment creation code in integration tests #643

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

jgiannuzzi
Copy link
Member

A lot of the code to create experiments in our integration tests has been copy/pasted over time and contains unnecessary parameters. This PR tries to minimize them. It also tries to differentiate the artifact locations of the experiments compared in the new flow tests.

@jgiannuzzi jgiannuzzi self-assigned this Nov 23, 2023
Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jgiannuzzi jgiannuzzi merged commit b202465 into G-Research:main Nov 23, 2023
17 checks passed
@jgiannuzzi jgiannuzzi deleted the cleanup-experiments branch November 23, 2023 16:36
@jgiannuzzi
Copy link
Member Author

Part of the work for #561.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants