Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assert and require in a more idiomatic way in our tests #634

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Use assert and require in a more idiomatic way in our tests #634

merged 1 commit into from
Nov 21, 2023

Conversation

jgiannuzzi
Copy link
Member

This PR changes the way we use assert and require to the more idiomatic way of using the test suite directly.

For example, this

assert.Equal(s.T(), expected, actual)

becomes

s.Equal(expected, actual)

@jgiannuzzi jgiannuzzi self-assigned this Nov 21, 2023
@jgiannuzzi jgiannuzzi merged commit 392b41f into G-Research:main Nov 21, 2023
@jgiannuzzi jgiannuzzi deleted the idiomatic-asserts branch November 21, 2023 10:24
@jgiannuzzi jgiannuzzi linked an issue Nov 24, 2023 that may be closed by this pull request
Integration tests: add a new way to run them against a new separate server instance per test #561
Closed
23 tasks
@jgiannuzzi
Copy link
Member Author

Part of the work for #561.

@jgiannuzzi jgiannuzzi mentioned this pull request Nov 24, 2023
Closed
23 tasks
@jgiannuzzi jgiannuzzi removed a link to an issue Nov 24, 2023
Integration tests: add a new way to run them against a new separate server instance per test #561
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsuhinin dsuhinin dsuhinin approved these changes

Assignees

@jgiannuzzi jgiannuzzi

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgiannuzzi @dsuhinin