Skip to content

Fix timestamp types in Aim integration tests #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

jgiannuzzi
Copy link
Member

This PR corrects the types used by timestamps in our Aim integration tests. We were incorrectly using integers whilst the API is returning floats. A couple of disabled assertions are also enabled.

@jgiannuzzi jgiannuzzi self-assigned this Nov 20, 2023
Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We have to start using object in AIM as soon as possible to create actual response objects.

@jgiannuzzi jgiannuzzi merged commit 56f6492 into G-Research:main Nov 20, 2023
@jgiannuzzi jgiannuzzi deleted the tests-aim-timestamps branch November 20, 2023 16:28
@jgiannuzzi
Copy link
Member Author

Part of the work for #561.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants