Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display and Update experiment description in aim UI #578

Merged
merged 39 commits into from
Nov 23, 2023
Merged

Display and Update experiment description in aim UI #578

merged 39 commits into from
Nov 23, 2023

Conversation

fabiovincenzi
Copy link
Collaborator

@fabiovincenzi fabiovincenzi commented Nov 13, 2023 •
edited
Loading

Fixes #522.
New UpdateExperiment endpoint in aim, which allows to edit experiment name, description and archived.
GetExperiment and GetExperiments now return the experiment description.
Update GetExperiment and GetExperiments integration tests to actually test experiment desciption.

@fabiovincenzi
Admin create namespace integration tests
ebd48cd
@fabiovincenzi
delete tests
72d05e7
@fabiovincenzi
update create tests
0e68678
@fabiovincenzi
uopdate tests
93a2836
@fabiovincenzi
Merge branch 'main' into admin-integration-tests
42c96c3
@fabiovincenzi
merge conflicts
bc99ae8
@fabiovincenzi
adressing comments
b29e9fb
@fabiovincenzi
Merge branch 'main' into admin-integration-tests
a7f1a64
@fabiovincenzi
addressing comments
c7e0854
@fabiovincenzi
Merge branch 'admin-integration-tests' of https://github.com/fabiovin…
0e484a6 
…cenzi/fasttrack into admin-integration-tests
@fabiovincenzi
fix duplicate namespace code error
8af027a
@fabiovincenzi
add html response type in client
1567bac
@fabiovincenzi
fix code formatting
b12dea9
@fabiovincenzi
remove unnecessary dependancy
65cf02f
@fabiovincenzi
implementing updateExperiment end point
b73dbdf
@fabiovincenzi
Merge branch 'G-Research:main' into experiment-description-aim-ui
1d8cf70
@fabiovincenzi
get experiments endpoint
f83531f
@fabiovincenzi
Merge branch 'experiment-description-aim-ui' of https://github.com/fa…
fc43c9d 
…biovincenzi/fasttrack into experiment-description-aim-ui
@fabiovincenzi
fix style
0b29563
@fabiovincenzi fabiovincenzi changed the title Experiment description aim UI Display and Update experiment description in aim UI Nov 13, 2023
@fabiovincenzi fabiovincenzi linked an issue Nov 13, 2023 that may be closed by this pull request
Add support for displaying and updating experiment description in Aim UI #522
Closed
@fabiovincenzi fabiovincenzi added enhancement New feature or request go Pull requests that update Go code labels Nov 14, 2023
@fabiovincenzi fabiovincenzi self-assigned this Nov 14, 2023
dave-gantenbein
dave-gantenbein reviewed Nov 14, 2023
View reviewed changes
pkg/api/aim/request/experoiment.go Outdated Show resolved Hide resolved
pkg/api/aim/experiments.go Show resolved Hide resolved
pkg/api/aim/response/experiment.go Outdated Show resolved Hide resolved
tests/integration/golang/helpers/experiment.go Show resolved Hide resolved
suprjinx
suprjinx previously approved these changes Nov 17, 2023
View reviewed changes
@fabiovincenzi fabiovincenzi merged commit bae3dbe into G-Research:main Nov 23, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsuhinin dsuhinin dsuhinin left review comments

@jgiannuzzi jgiannuzzi jgiannuzzi left review comments

@dave-gantenbein dave-gantenbein dave-gantenbein left review comments

@suprjinx suprjinx suprjinx approved these changes

Assignees

@fabiovincenzi fabiovincenzi

Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for displaying and updating experiment description in Aim UI
5 participants
@fabiovincenzi @dave-gantenbein @suprjinx @jgiannuzzi @dsuhinin