Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and restore the golangci-lint cache in our CI #553

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

jgiannuzzi
Copy link
Member

This PR is the third in a series to address #328.

It introduces steps to save and restore the golangci-lint cache during the go-lint job in our CI. It also cleans up the golangci-lint configuration to remove options that do not exist anymore and improve the output format.

@jgiannuzzi jgiannuzzi self-assigned this Nov 5, 2023
@jgiannuzzi jgiannuzzi added the ci CI related label Nov 5, 2023
@jgiannuzzi jgiannuzzi marked this pull request as ready for review November 9, 2023 20:55
Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicee!

@jgiannuzzi jgiannuzzi merged commit 10d6962 into G-Research:main Nov 10, 2023
18 checks passed
@jgiannuzzi jgiannuzzi deleted the golangci-cache branch November 10, 2023 05:31
@jgiannuzzi jgiannuzzi linked an issue Nov 10, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Go caching in CI
2 participants