Integrate auth logic into mlflow, aim, admin, chooser parts #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ooser` parts. move `/namespaces/current` and `namespaces/list` endpoints to `chooser` part.
suprjinx
reviewed
Mar 27, 2024
suprjinx
reviewed
Mar 27, 2024
| if authToken == nil || !authToken.HasUserAccess(namespace.Code) { | ||
| return ctx.Status( | ||
| http.StatusNotFound, | ||
| ).JSON( |
There was a problem hiding this comment.
Since this is chooser, maybe we should provide plain text response instead of JSON? or, ideally, HTML.
There was a problem hiding this comment.
yes, plain test response is reasonable. rendering html inside the middleware not a good approach I think. probably in such cases works well forwarding to error page.
There was a problem hiding this comment.
so I think now we can just send something plain.
suprjinx
previously approved these changes
Mar 27, 2024
…dsuhinin/user-auth-part-2
suprjinx
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 2/2 part. Whats inside the box:
mlflow,aim,admin,chooserparts.