Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove metric querying support #1019

Merged
merged 27 commits into from
Mar 21, 2024
Merged

Remove metric querying support #1019

merged 27 commits into from
Mar 21, 2024

Conversation

fabiovincenzi
Copy link
Collaborator

Fixes #866.

  • Removing metric. support
  • Filter the requested metrics using a list of metric_key+context instead of using the query
  • Adapt SearchMetrics integration tests to work with the new logic

fabio vincenzi and others added 17 commits March 13, 2024 11:13
dsuhinin
dsuhinin previously approved these changes Mar 20, 2024
View reviewed changes
suprjinx
suprjinx approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fabiovincenzi fabiovincenzi merged commit 2372687 into G-Research:main Mar 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsuhinin dsuhinin dsuhinin left review comments

@suprjinx suprjinx suprjinx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Faster Aim UI: Remove metric querying support
3 participants
@fabiovincenzi @suprjinx @dsuhinin