Project Params Hotfix (#62)

* Hotfix: Add support for experimentNames in getProjectParams * Fetch project params on selectedExperiment change
G-Research · Apr 8, 2024 · ea4e25f · ea4e25f
1 parent a4ea0f1
commit ea4e25f
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 9 deletions.
diff --git a/src/src/services/api/projects/projectsService.ts b/src/src/services/api/projects/projectsService.ts
@@ -24,14 +24,17 @@ function fetchActivityData(): IApiRequest<any> {
 
 function getProjectParams(
   sequences: string[] = ['metric'],
+  selectedExperimentNames: string[] = [],
 ): IApiRequest<IProjectParamsMetrics> {
-  const query = sequences.reduce(
-    (acc: string, sequence: string, index: number) => {
+  const query =
+    sequences.reduce((acc: string, sequence: string, index: number) => {
       acc += `${index === 0 ? '?' : '&'}sequence=${sequence}`;
       return acc;
-    },
-    '',
-  );
+    }, '') +
+    selectedExperimentNames.reduce((acc: string, experimentName: string) => {
+      acc += `&experiment_names=${experimentName}`;
+      return acc;
+    }, '');
   return API.get<IProjectParamsMetrics>(endpoints.GET_PROJECTS_PARAMS + query);
 }
 

diff --git a/src/src/services/models/explorer/createAppModel.ts b/src/src/services/models/explorer/createAppModel.ts
@@ -559,8 +559,10 @@ function createAppModel(appConfig: IAppInitialConfig) {
     }
 
     function fetchProjectParamsAndUpdateState() {
+      const selectedExperimentNames =
+        model.getState()?.config?.select.selectedExperimentNames;
       projectsService
-        .getProjectParams(['metric'])
+        .getProjectParams(['metric'], selectedExperimentNames)
         .call()
         .then((data) => {
           const advancedSuggestions: Record<any, any> = getAdvancedSuggestion(
@@ -2016,6 +2018,7 @@ function createAppModel(appConfig: IAppInitialConfig) {
         onSelectExperimentNamesChange(experimentName: string): void {
           // Handle experiment change, then re-fetch metrics data
           onSelectExperimentNamesChange({ experimentName, model });
+          fetchProjectParamsAndUpdateState();
           getMetricsData(true, true).call();
         },
         onToggleAllExperiments(experimentNames: string[]): void {
@@ -2232,9 +2235,11 @@ function createAppModel(appConfig: IAppInitialConfig) {
           setModelDefaultAppConfigData();
         }
 
+        const selectedExperimentNames =
+          model.getState()?.config?.select?.selectedExperimentNames;
         const liveUpdateState = model.getState()?.config.liveUpdate;
         projectsService
-          .getProjectParams(['metric'])
+          .getProjectParams(['metric'], selectedExperimentNames)
           .call()
           .then((data) => {
             model.setState({
@@ -3281,8 +3286,10 @@ function createAppModel(appConfig: IAppInitialConfig) {
             chartPanelRef: { current: null },
           };
         }
+        const selectedExperimentNames =
+          model.getState()?.config?.select?.selectedExperimentNames;
         projectsService
-          .getProjectParams(['metric'])
+          .getProjectParams(['metric'], selectedExperimentNames)
           .call()
           .then((data) => {
             model.setState({
@@ -4894,8 +4901,10 @@ function createAppModel(appConfig: IAppInitialConfig) {
         }
         const liveUpdateState = model.getState()?.config?.liveUpdate;
 
+        const selectedExperimentNames =
+          model.getState()?.config?.select.selectedExperimentNames;
         projectsService
-          .getProjectParams(['metric'])
+          .getProjectParams(['metric'], selectedExperimentNames)
           .call()
           .then((data: IProjectParamsMetrics) => {
             model.setState({