Skip to content

Unblocking consul agent versions updater #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Unblocking consul agent versions updater #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a65a08a
1.6.10
marcin-krystianc Jan 21, 2025
d5365c7
Merge branch 'master' into dev-20250121-v16
marcin-krystianc Jan 21, 2025
2d20612
Merge branch 'master' into dev-20250121-v16
marcin-krystianc Jan 22, 2025
74634e1
Merge branch 'master' into dev-20250121-v16
marcin-krystianc Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
if: github.event_name == 'push' || github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id
strategy:
matrix:
consul: [1.7.14, 1.8.19, 1.9.17, 1.10.12, 1.11.11, 1.12.9, 1.13.9, 1.14.11, 1.15.10, 1.16.6, 1.17.3, 1.18.2, 1.19.2, 1.20.0]
consul: [1.6.10, 1.7.14, 1.8.19, 1.9.17, 1.10.12, 1.11.11, 1.12.9, 1.13.9, 1.14.11, 1.15.10, 1.16.6, 1.17.3, 1.18.2, 1.19.2, 1.20.0]
framework: [net461, net8.0] # Latest LTS
os: [ubuntu-latest, windows-latest, macos-latest]
include:
Expand Down
6 changes: 5 additions & 1 deletion Consul.Test/ConnectTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using NuGet.Versioning;
using Xunit;

namespace Consul.Test
Expand Down Expand Up @@ -55,9 +56,12 @@ public async Task Connect_GetCAConfigurationTest()
Assert.NotEqual((ulong)0, result.ModifyIndex);
}

[Fact]
[SkippableFact]
public async Task Connect_CASetConfig()
{
var cutOffVersion = SemanticVersion.Parse("1.7.0");
Skip.If(AgentVersion < cutOffVersion, $"Current version is {AgentVersion}, but setting CA config is only supported from Consul {cutOffVersion}");

var req = await _client.Connect.CAGetConfig();
var config = req.Response;

Expand Down
Loading