Skip to content

restore default port 8500 for CONSUL_HTTP_ADDR (#394) #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 15, 2024
Merged

restore default port 8500 for CONSUL_HTTP_ADDR (#394) #395

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8cf99e1
restore default port 8500 for CONSUL_HTTP_ADDR when no port is specif…
larrytamnjong Nov 12, 2024
b90470e
update check for default port 80 and add test for CONSUL_HTTP_ADDR pa…
larrytamnjong Nov 14, 2024
98e6456
add more cases to Client_DefaultConfig_env (#394)
larrytamnjong Nov 14, 2024
0b4bfed
update test
larrytamnjong Nov 14, 2024
3fc7620
Update test (#394)
larrytamnjong Nov 14, 2024
00c7f4f
Update HTTP scheme to HTTPS
larrytamnjong Nov 14, 2024
b1d654d
remove redundant condition
larrytamnjong Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Consul/Client.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ private void ConfigureFromEnvironment(UriBuilder consulAddress)
consulAddress.Host = uri.Host;
}

consulAddress.Port = uri.Port;
consulAddress.Port = uri.IsDefaultPort ? 8500 : uri.Port;
consulAddress.Path = uri.AbsolutePath;
}

Expand Down