add admin partition create API support (#379) #380
Conversation
marcin-krystianc
left a comment
marcin-krystianc
left a comment
There was a problem hiding this comment.
These changes look good, but because we are unable to test it I think we should park these PR for now. If it will be possible to run enterprise tests for versions newer than 1.10, we will get back to it.
| [EnterpriseOnlyFact] | ||
| public async Task AdminPartition_CreateAdminPartition() | ||
| { | ||
| var cutOffVersion = SemanticVersion.Parse("1.11.0"); |
There was a problem hiding this comment.
Unfortunately, as for now we will not be able to run enterprise tests for versions 1.10+, so these test is going to be skipped, e.g.:
[xUnit.net 00:00:20.03] Consul.Test.AdminPartitionTest.AdminPartition_CreateAdminPartition [SKIP]
[xUnit.net 00:00:20.03] Skipped; this test requires a consul enterprise server to run.
We run enterprise tests only for versions before 1.10 -> https://github.com/G-Research/consuldotnet/blob/master/.github/workflows/ci.yml#L82-L88
I'm afraid we will not be able accept this PR because we are unable to test it at the moment.
There was a problem hiding this comment.
@marcin-krystianc makes sense, thanks. Please take a look at this other PR #382 when you have time.
2 participants
No description provided.