Add Discovery Chain Post #378
Conversation
marcin-krystianc
left a comment
marcin-krystianc
left a comment
There was a problem hiding this comment.
Hi @larrytamnjong,
I left comments about compile-dc argument, looks good otherwise!
Consul/DiscoveryChain.cs
Outdated
|
|
||
| public class DiscoveryChainOptions | ||
| { | ||
| public string EvaluateInDatacenter { get; set; } |
There was a problem hiding this comment.
I think this should not be a part of this structure as it is being used as [compile-dc](https://developer.hashicorp.com/consul/api-docs/discovery-chain#compile-dc) which is a query-only parameter.
Consul/DiscoveryChain.cs
Outdated
| var request = _client.Post<DiscoveryChainOptions, DiscoveryChainResponse>($"/v1/discovery-chain/{name}", options, q); | ||
| if (options != null && options.EvaluateInDatacenter != null) | ||
| { | ||
| request.Params["compile-dc"] = options.EvaluateInDatacenter; |
There was a problem hiding this comment.
This should be a separate argument passed to the Get method.
Thanks @marcin-krystianc I have made an update based on your feedback. |
marcin-krystianc
left a comment
marcin-krystianc
left a comment
There was a problem hiding this comment.
Looks good, please just remove those unnecessary empty lines.
Consul.Test/DiscoveryChainTest.cs
Outdated
| Assert.Equal(targetCheck.Name, targetChain.Name); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Nit: Please remove extra empty lines
Consul.Test/DiscoveryChainTest.cs
Outdated
| } | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Nit: Please remove extra empty lines
Consul.Test/DiscoveryChainTest.cs
Outdated
|
|
||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: Please remove extra empty lines
Done :) |
3 participants
#355