Skip to content

[CI] Install the version of dotnet defined in global.json #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 14, 2024
Merged

[CI] Install the version of dotnet defined in global.json #372

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
038d7b9
fix the formatter's job
marcin-krystianc Oct 14, 2024
c2daa84
Do not cache
marcin-krystianc Oct 14, 2024
1e13560
Revert "Do not cache"
marcin-krystianc Oct 14, 2024
a4c6232
let's try using global.json's version
marcin-krystianc Oct 14, 2024
442edbc
clean it up
marcin-krystianc Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .github/workflows/formatter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,10 @@ jobs:
repository: ${{ github.event.pull_request.head.repo.full_name }}
ref: ${{ github.head_ref }}

- name: Cache .NET tools
uses: actions/cache@v4
with:
path: ~/.nuget/packages
key: dotnet-tools-${{ runner.os }}-${{ hashFiles('.config/dotnet-tools.json') }}
restore-keys: dotnet-tools-${{ runner.os }}-

- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: 7.0.x
dotnet-version: 8.0.x
Copy link
Member

@nojaf nojaf Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you drop the dotnet-version it takes the one found from the global.json

Copy link
Contributor Author

@marcin-krystianc marcin-krystianc Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, indeed it works. I didn't know that trick. Thanks!


- name: Restore tools
run: dotnet tool restore
Expand Down
Loading