Add GET List Ingress Health for Service #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….cs, added possible test, changed test_config for the test
…ARoots and Root classes
…alNumber of Root class, due to a fail at version 1.6.10
…an 1.7.0 The field seems to be initialized to 0 in versions <= 1.7.0, which was causing a testing error
Add connect ca roots
Fix connect ca roots
…s, modified IAgentEndpoint.cs to have GetCALeaf
Add connect ca leaf
…thod to IAgendEndpoint.cs
…overload to ConnectAuthorize to support WriteOptions
Add connect authorize
Had to Add TerminatingGatewayConfigEntry and IngressGatewayConfigEntry classes for testing purposes
…ed Configuration.cs to have correct classes Changed name TerminalGatewayEntry to TerminatingGatewayEntry
Co-authored-by: Marcin Krystianc <[email protected]>
…olchanov/consuldotnet into add-update-lan-coordinates
…nov/consuldotnet into add-gateaway-services
Add update lan coordinates
Add gateaway services
Updating branch add-list-ingress-health
Added endpoint and tests, had to change Node in Catalog.cs because it lacked a field
Contributor
marcin-krystianc
left a comment
marcin-krystianc
left a comment
There was a problem hiding this comment.
looks, good. Just a few minor comments.
| { | ||
| Name = "foo-ingress-gateway", | ||
| Listeners = new List<GatewayListener> | ||
| { |
Contributor
There was a problem hiding this comment.
Odd formatting, should be:
Listeners = new List<GatewayListener>
{
...
Consul.Test/HealthTest.cs
Outdated
|
|
||
| var services = await _client.Health.Ingress("foo-ingress", "", false); | ||
| Assert.Single(services.Response); | ||
| Assert.Equal("dc1", services.Response[0].Node.Datacenter); |
Contributor
There was a problem hiding this comment.
It is better to assert that the data center is not empty ( to make the test independent from external configuration).
…hanov/consuldotnet into add-list-ingress-health
Contributor
Author
|
@marcin-krystianc fixed everything, I think |
marcin-krystianc
approved these changes
Jul 18, 2024
Contributor
marcin-krystianc
left a comment
marcin-krystianc
left a comment
There was a problem hiding this comment.
Nice, thank you.
IvanKolchanov
changed the title
This was referenced Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added endpoint and tests for it, had to change Node in Catalog.cs because it lacked a field
Resolves #349