-
Notifications
You must be signed in to change notification settings - Fork 94
Read LAN Coordinates for a specific node #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcin-krystianc
merged 20 commits into
G-Research:master
from
JocelynVelarde:#313-read-node-coordinates
Apr 29, 2024
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a815eb7
Read LAN Coordinates for a specific node
JocelynVelarde ec27430
Fix endpoint overload
JocelynVelarde 47f160a
Added query parameter to test and changed to return node array
JocelynVelarde ce83113
Test fix
JocelynVelarde 81f30a8
fixed unit testing
JocelynVelarde 0d9f8bc
style: fix whitespaces
octocat 8155cdd
updated wait time and condition in base fixture class
JocelynVelarde 853e938
Merge branch '#313-read-node-coordinates' of https://github.com/Jocel…
JocelynVelarde 79bac98
style: fix whitespaces
octocat 7be9a9c
syntax error fix
JocelynVelarde d06c16a
.
JocelynVelarde f3d89c7
style: fix whitespaces
octocat ed2bd2c
test alternative for node coordinate
JocelynVelarde 2f2941a
fix merge
JocelynVelarde 5b2ed3e
reverted test for individual node
JocelynVelarde 1e89e43
style: fix whitespaces
octocat f147e92
deleted comments
JocelynVelarde ef9e81d
Merge branch '#313-read-node-coordinates' of https://github.com/Jocel…
JocelynVelarde c1c1840
Merge branch 'master' into #313-read-node-coordinates
marcin-krystianc f462ed0
Merge branch 'master' into #313-read-node-coordinates
marcin-krystianc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous version of the test was better, we did actually use a real node name in the query before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is that with the node name I was receiving errors in the base fixture class