Added Support for Getting Service Configuration #278
Merged
+121
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-krystianc
previously approved these changes
Dec 1, 2023
Contributor
marcin-krystianc
left a comment
marcin-krystianc
left a comment
There was a problem hiding this comment.
I think it would be more consistent with the rest of the system, to use ServiceId capitalisation.
I know that we have form ``ServiceIDin some classes, but as a parameter in a methodServiceId` form seems more suitable.
Contributor
Author
|
done |
marcin-krystianc
approved these changes
Dec 1, 2023
This was referenced Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276
@marcin-krystianc