Skip to content

Conversation

@sammychinedu2ky
Copy link
Contributor

Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are just a few minor comments to be addressed in the test, but overall it looks good.

@sammychinedu2ky
Copy link
Contributor Author

Thanks done @marcin-krystianc

Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sammychinedu2ky,

one more thing. Since we rely on the CONSUL_AGENT_CONFIG_PATH to be set, we need to set it in the CI workflow so the test is actually run 😄

@sammychinedu2ky
Copy link
Contributor Author

Alright 👌

- name: Run tests
shell: bash
run: |
export CONSUL_AGENT_CONFIG_PATH=$GITHUB_WORKSPACE/Consul.Test/test_config.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using export, you can use env context in line 133

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched it now 😄

@sammychinedu2ky
Copy link
Contributor Author

sammychinedu2ky commented Nov 6, 2023

Hi @marcin-krystianc , some test cases passed and some didn't
In some instances it said

 Expected: DEBUG
Actual:   TRACE

and in some instances it said

The given key was not present in the dictionary.

@sammychinedu2ky
Copy link
Contributor Author

Hi @marcin-krystianc please do you know the reason behind that

@sammychinedu2ky
Copy link
Contributor Author

@marcin-krystianc . I think I would use the skippable feature here

@marcin-krystianc
Copy link
Contributor

@marcin-krystianc . I think I would use the skippable feature here

Makes sense.

@sammychinedu2ky
Copy link
Contributor Author

done @marcin-krystianc

Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Added Test for Agent Reload

3 participants