fix: write correct value for KV.Release

[winstxnhdw]

• Closes KV.Release is writing a wrong value #138
• Add unit test for this issue
• Apply minor lint changes

[marcin-krystianc]

In the KV_AcquireRelease test, I would also:

• assert that the value in the acquired KV is "test"
• set the current value to "test2"
• assert that the value in the released KV is "test2"

[marcin-krystianc]

I think that the test parameters here don't add any value. My intention in the previous comment was that we use different text values for Acquire and for Release, so we can check what value is being written by Release.

[winstxnhdw]

Not exactly sure if I understand what the difference would be.

[marcin-krystianc]

Not exactly sure if I understand what the difference would be.

I want to assert that Release operation releases the KV but also writes a new value.

[marcin-krystianc]

No need to call the Acquire again.

[winstxnhdw]

Without acquiring again, the test will fail..

[marcin-krystianc]

Strange, I'm sure I tested it locally yesterday and it worked, but now it seems it doesn't work anymore, investigating...

[marcin-krystianc]

Ah, I found it. You have the release operation twice, but it should be called only once like this:

 [Fact]
        public async Task KV_AcquireRelease()
        {
            var sessionRequest = await _client.Session.CreateNoChecks(new SessionEntry());
            var id = sessionRequest.Response;

            Assert.False(string.IsNullOrEmpty(sessionRequest.Response));

            var key = GenerateTestKeyName();
            var value = "test";

            var pair = new KVPair(key)
            {
                Value = Encoding.UTF8.GetBytes(value),
                Session = id,
            };

            var acquireRequest = await _client.KV.Acquire(pair);
            Assert.True(acquireRequest.Response);

            var getRequest = await _client.KV.Get(key);

            Assert.NotNull(getRequest.Response);
            Assert.Equal(id, getRequest.Response.Session);
            Assert.Equal(getRequest.Response.LockIndex, (ulong)1);
            Assert.True(getRequest.LastIndex > 0);

            pair.Value = Encoding.UTF8.GetBytes("test2");
            var releaseRequest = await _client.KV.Release(pair);
            Assert.True(releaseRequest.Response);

            getRequest = await _client.KV.Get(key);
            Assert.NotNull(getRequest.Response);
            Assert.Equal("test2", Encoding.UTF8.GetString(getRequest.Response.Value));
            Assert.Null(getRequest.Response.Session);
            Assert.Equal(getRequest.Response.LockIndex, (ulong)1);
            Assert.True(getRequest.LastIndex > 0);

            var sessionDestroyRequest = await _client.Session.Destroy(id);
            Assert.True(sessionDestroyRequest.Response);

            var deleteRequest = await _client.KV.Delete(key);
            Assert.True(deleteRequest.Response);
        }