Statistics test updates for Arrow 6.0.0#238
Merged
jgiannuzzi merged 3 commits intoG-Research:Arrow-6.0.0from Dec 2, 2021
Merged
Statistics test updates for Arrow 6.0.0#238jgiannuzzi merged 3 commits intoG-Research:Arrow-6.0.0from
jgiannuzzi merged 3 commits intoG-Research:Arrow-6.0.0from
Conversation
Contributor
adamreeve
commented
Dec 1, 2021
adamreeve
commented
- Re-enables checking of null counts, which were previously broken for array valued columns
- Re-enables checking min/max for decimals, which has been fixed since Arrow 4.0
These were previously incorrect for array valued columns but have been fixed in Arrow 6.0. See https://issues.apache.org/jira/browse/PARQUET-2067.
These have been fixed since Arrow 4.0. See https://issues.apache.org/jira/browse/PARQUET-1655
jgiannuzzi
approved these changes
Dec 2, 2021
Member
|
Thanks a lot @adamreeve! |
jgiannuzzi
pushed a commit
that referenced
this pull request
Jan 14, 2022
* Re-enable null-count checks in statistics tests These were previously incorrect for array valued columns but have been fixed in Arrow 6.0. See https://issues.apache.org/jira/browse/PARQUET-2067. * Re-enable min/max statistics tests for decimal These have been fixed since Arrow 4.0. See https://issues.apache.org/jira/browse/PARQUET-1655 * Get decimal multiplier from column descriptor for min/max statistics tests
jgiannuzzi
added a commit
that referenced
this pull request
Jan 14, 2022
* Update to Arrow-6.0.0 * Review enums * Update ParquetVersion enum * Update Encoding enum * Fix unit tests (schema version) * Enable standard __cpluscplus macro with MSVC * Bump version to 6.0.0-beta1 * Statistics test updates for Arrow 6.0.0 (#238) * Re-enable null-count checks in statistics tests These were previously incorrect for array valued columns but have been fixed in Arrow 6.0. See https://issues.apache.org/jira/browse/PARQUET-2067. * Re-enable min/max statistics tests for decimal These have been fixed since Arrow 4.0. See https://issues.apache.org/jira/browse/PARQUET-1655 * Get decimal multiplier from column descriptor for min/max statistics tests * Point to arrow-6.0.0 PR merge on vcpkg master microsoft/vcpkg#21113 * Point to arrow-6.0.1 PR merge on vcpkg master microsoft/vcpkg#22084 * Fix unit tests (schema version) * Bump version to 6.0.1-beta1 Co-authored-by: Adam Reeve <adreeve@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.