Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support providing parse-as per lockfile / directory #189

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

G-Rath
Copy link
Owner

@G-Rath G-Rath commented Apr 27, 2023

This is effectively abusing a string to represent what is actually a tuple, and does mean we're doing a little extra work sometimes because we parse at least twice, but overall it works pretty nice imo so I think for now at least it's fine as doing something like a tuple would make it more complex 🤷

@G-Rath G-Rath added the enhancement New feature or request label Apr 27, 2023
@G-Rath G-Rath force-pushed the improve-parse-as branch from 727ba04 to 8fe6e9b Compare April 27, 2023 22:53
@G-Rath G-Rath force-pushed the improve-parse-as branch from 8fe6e9b to af47b6c Compare April 27, 2023 23:08
@G-Rath G-Rath merged commit 7aa4c79 into main Apr 27, 2023
@G-Rath G-Rath deleted the improve-parse-as branch April 27, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant