Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed a nice screensaver so we don't depend on XScreensaver #267

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from

Conversation

andydotxyz
Copy link
Contributor

@andydotxyz andydotxyz commented Jan 25, 2025

Description:

Still needs:

  • Inhibit when requested by movie players etc
  • Multiple monitor support

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.
  • Public APIs match existing style.

@coveralls
Copy link

coveralls commented Jan 25, 2025

Pull Request Test Coverage Report for Build 13619428951

Details

  • 26 of 243 (10.7%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 23.322%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/ui/menu.go 0 6 0.0%
internal/x11/wm/events.go 0 6 0.0%
internal/ui/desk.go 10 17 58.82%
internal/x11/wm/desk.go 0 9 0.0%
internal/ui/settings_ui.go 0 17 0.0%
internal/ui/embed_wm.go 13 34 38.24%
internal/ui/settings.go 3 33 9.09%
internal/x11/wm/screensaver.go 0 35 0.0%
internal/ui/screensaver.go 0 86 0.0%
Files with Coverage Reduction New Missed Lines %
internal/ui/settings_ui.go 1 0.0%
Totals Coverage Status
Change from base Build 13607336956: -0.5%
Covered Lines: 1237
Relevant Lines: 5304

💛 - Coveralls

@taigrr taigrr self-requested a review February 9, 2025 01:17
Copy link
Member

@taigrr taigrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we kinda have half-support for multimonitor through xscreensaver right? Just not if xscreensaver isn't installed?

@andydotxyz
Copy link
Contributor Author

Yes the xscreensaver plugin supports multi-monitor but the replacement with Fyne does not yet. Other than that it seems to be working quite well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants