Accounting for media in Text comparators
#1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
maykcaldas,
mskarlin,
nadolskit,
sidnarayanan and
whitead
dosubot
bot
added
the
size:M
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the media field is properly considered when comparing and hashing Text objects, maintaining consistency between equality and hash operations.
- Added
mediacomparison to the__eq__method of theTextclass - Updated
__hash__to includemedia(converted to tuple for hashability) - Added comprehensive tests for
Textequality and hashing with media
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/paperqa/types.py | Updated Text.__eq__ to compare media field and Text.__hash__ to include media in the hash calculation |
| tests/test_paperqa.py | Added test_text_comparison to verify equality and hashing behavior with and without media |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
whitead
approved these changes
Nov 4, 2025
maykcaldas
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1046 missed updating
Text.__eq__/__hash__