-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Labels
bugSomething isn't workingSomething isn't working
Description
I noticed that my embeddings kept getting rate-limited without retries. On investigation:
embed_kwargs
is a field, but is not consumed anywhere: https://github.com/Future-House/llm-client/blob/main/llmclient/embeddings.py#L77-L80. We should probably remove itconfig["kwargs"]
appears to be the way to do it, and we do have a validator to set a default, butvalidate_default
is not set, and so it is not called:
>>> LiteLLMEmbeddingModel().config
{}
For now, if one wants to retry, do something like:
LiteLLMEmbeddingModel(config={"kwargs": {"num_retries": 3, "timeout": 60}})
I can put a patch in later, but wanted to solicit feedback on if anyone wants embed_kwargs
or if we can put everything in config
.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working