Gad 2 2025 latest #1449
Gad 2 2025 latest #1449
Conversation
Co-authored-by: A Anunaya <[email protected]> Co-authored-by: Aksh Bansal <[email protected]>
| migrations.CreateModel( | ||
| name='Requests', | ||
| fields=[ | ||
| ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')), | ||
| ('name', models.CharField(max_length=200)), | ||
| ('description', models.CharField(max_length=200)), | ||
| ('area', models.CharField(max_length=200)), | ||
| ('requestCreatedBy', models.CharField(max_length=200)), | ||
| ('engineerProcessed', models.IntegerField()), | ||
| ('directorApproval', models.IntegerField()), | ||
| ('deanProcessed', models.IntegerField()), | ||
| ('status', models.CharField(max_length=200)), | ||
| ], |
There was a problem hiding this comment.
Any particular reason behind deleting these ?? Like Ig these are auto-generated?
There was a problem hiding this comment.
These changes were actually giving errors after running migrations in Anudeep's laptop. The requests model was implemented by us but while making migrations it got added in the 0001_initial.py file. So he told me to remove this piece of code.
| elif profile['user_type'] == 'staff': | ||
| resp = { | ||
| 'user' : user_detail, | ||
| 'profile' : profile, | ||
| } | ||
| return Response(data=resp, status=status.HTTP_200_OK) |
There was a problem hiding this comment.
And why are we removing the case when the user is staff?
There was a problem hiding this comment.
This piece of code was added by the dashboard module member in my local setup and we forgot to revert it back, he told that these changes should not be here and these changes will be reflected in the PR they would raise after their implementation is completed.
|
Ping Integration leads plss to raise a PR for the |
7 participants
Issue that this pull request solves
Removed the changes in the globals/api/views.py
Closes: # (issue number)
Proposed changes
Unwanted changes have been reverted
Brief description of what is fixed or changed
The unwanted changes in globals have been removed and users can only access the urls after logging in
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
https://drive.google.com/drive/folders/1iQBxUOuhojei7qLjph9K1bhximrseokW?usp=sharing
Please attach the screenshots of the changes made in case of change in user interface
Other information
@varun7singh
@ChaudharyRaman
@prajjwalkapoor
Any other information that is important to this pull request