Skip to content

Conversation

Srivatsa19
Copy link

@Srivatsa19 Srivatsa19 commented Apr 11, 2024

Issue that this pull request solves

Added functionality where only logged in users can access the module. The module has been implemented according to the use case diagram
Closes: # (issue number)

Proposed changes

  1. Error Handling where users were able to access the module without logging in.
  2. Fixed the drop down with the correct designations on line 818 in the views.py file.

Brief description of what is fixed or changed

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

https://drive.google.com/drive/folders/1iQBxUOuhojei7qLjph9K1bhximrseokW?usp=sharing
Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

The designations used in the module are :-
designations_list = ["Junior Engineer", "Executive Engineer (Civil)", "Electrical_AE", "Electrical_JE", "EE", "Civil_AE", "Civil_JE", "Dean (P&D)", "Director", "Accounts Admin", "Admin IWD", "Auditor"]

ajay --> Junior Engineer
dvijay --> Executive Engineer (Civil)
de --> Dean (P&D)
dir --> Director
richard --> Accounts Admin
iwdAdmin --> Admin IWD
kunal --> Auditor

@varun7singh
@ChaudharyRaman
@prajjwalkapoor

@Aragorn-64
Copy link

@Srivatsa19 please fill the format of the PR, add relevant information and add screenshots + usage video

@Aragorn-64
Copy link

Filetracking part seems to work properly, and PR format is followed. Looks good

@Aragorn-64
Copy link

I think its ready to merge @prajjwalkapoor

@prajjwalkapoor
Copy link

LGTM, merging.

@prajjwalkapoor prajjwalkapoor merged commit 0c67de0 into FusionIIIT:gad-2 Apr 14, 2024
@anudeeps0306
Copy link
Contributor

FusionIIIT/applications/globals/api/views.py, I talked with the dashboard team, and this change is not supposed to be here.
0001_initial.py has been changed, which will cause an error during migrations. Hence you need to remove these lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants