Skip to content

Conversation

Aragorn-64
Copy link

Issue that this pull request solves

Closes: # (issue number)

Proposed changes

Brief description of what is fixed or changed

Edit drafts now uses Dropdown designation,
Forward file now uses Dropdown designation,
Error on "Faculty" or "Staff" dropdown opening /filetracking now gives meaningful message
Save as draft now saves the remarks added

Types of changes

Bug fixes and 1 addition of invalid_designation decorator

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Screenshot from 2024-04-11 01-15-47
Screenshot from 2024-04-11 01-16-01

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

Lawful2002 and others added 30 commits February 23, 2023 14:32
Co-authored-by: A Anunaya <[email protected]>
Co-authored-by: Aksh Bansal <[email protected]>
@Aragorn-64
Copy link
Author

@prajjwalkapoor Please take a look, thanks

@Priyansh61
Copy link

@Aragorn-64 Can you add a screen cast of the feature or the change made in the PR? Thanks

@theoden42
Copy link

theoden42 commented Apr 10, 2024

@Bhavik-ag @Priyansh61 Here is the link for the screen cast Video Link

The testing of GAD-4 identified some issues which were caused by update in the dashboard:

  • The dashboard had options such as 'faculty' and 'staff' which are userTypes, but FTS requires specific designations like 'Professor', 'HOD' to function. To fix this, we created a decorator which would redirect to a page signifying the same.

  • Edit Draft was not updated to include designations from those used in the sessions(dashboard) and is now working

  • Same as above for forward file

@Aragorn-64 Aragorn-64 changed the title Fix edit draft functionality and usertype Access GAD-4: Fix edit draft functionality and usertype Access Apr 11, 2024
Copy link

@Bhavik-ag Bhavik-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 !!

@theoden42
Copy link

@prajjwalkapoor pls merge this PR

@prajjwalkapoor prajjwalkapoor merged commit 9c38b48 into FusionIIIT:gad-4 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.