-
Notifications
You must be signed in to change notification settings - Fork 1.2k
GAD-4: Fix edit draft functionality and usertype Access #1410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: A Anunaya <[email protected]> Co-authored-by: Aksh Bansal <[email protected]>
… serializers and minor bug fixes
add api for android
@prajjwalkapoor Please take a look, thanks |
@Aragorn-64 Can you add a screen cast of the feature or the change made in the PR? Thanks |
@Bhavik-ag @Priyansh61 Here is the link for the screen cast Video Link The testing of GAD-4 identified some issues which were caused by update in the dashboard:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 !!
@prajjwalkapoor pls merge this PR |
Issue that this pull request solves
Closes: # (issue number)
Proposed changes
Brief description of what is fixed or changed
Edit drafts now uses Dropdown designation,
Forward file now uses Dropdown designation,
Error on "Faculty" or "Staff" dropdown opening /filetracking now gives meaningful message
Save as draft now saves the remarks added
Types of changes
Bug fixes and 1 addition of invalid_designation decorator
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that applyScreenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request