[SPACS] Code Improvements and Module Upgrade #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajwad-shaikh
commented
May 24, 2020
ajwad-shaikh
commented
- Code Readability improvements
- Database tables refactored to match code syntax
- MCM form field bug fixes
- MCM Submit fatality fixed
- Catalog errors fixed
- Code redundancy reduced
salarx
suggested changes
May 24, 2020
There was a problem hiding this comment.
There's a bit confusion regarding the word 'notional'. https://www.iitk.ac.in/dosa/DOSA/scholarship.htm
Even IITK have used this word
Not sure what's the real word to be used. Needs review.
This reverts commit b49c3c8.
|
@salarx Agreed. It is indeed notional prizes. Reverted last commit |
|
Looks good to me. You can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.