OS-2: Week-10: Fixed all the ambulance use cases #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approve @akshatnema |
akshatnema
requested changes
Apr 15, 2023
| var end=new Date(endDate); | ||
| var today = new Date(new Date().setHours(0, 0, 0, 0)); | ||
|
|
||
| console.log("Was here:::") |
There was a problem hiding this comment.
Suggested change
| console.log("Was here:::") |
| }); | ||
| </script> | ||
| <p id="dte"></p> | ||
| <!-- <p id="dte"></p> --> |
There was a problem hiding this comment.
Suggested change
| <!-- <p id="dte"></p> --> |
| }); | ||
| </script> | ||
| <p id="dte"></p> | ||
| <!-- <p id="dte"></p> --> |
There was a problem hiding this comment.
Suggested change
| <!-- <p id="dte"></p> --> |
| <div class="ui fluid input"> | ||
| <textarea class="ui textarea" rows="2" id="reason" name="reason"></textarea> | ||
| <p id="reas"></p> | ||
| <!-- <p id="reas"></p> --> |
There was a problem hiding this comment.
Suggested change
| <!-- <p id="reas"></p> --> |
There was a problem hiding this comment.
@akshatnema I've applied the suggested changes. PTAL.
|
Review required from @PranshuNayak and @samay-rgb |
PranshuNayak
requested changes
Apr 15, 2023
divyanshkhetan
changed the title
samay-rgb
reviewed
Apr 16, 2023
There was a problem hiding this comment.
Do not push indentation changes
samay-rgb
reviewed
Apr 16, 2023
There was a problem hiding this comment.
Remove this file from PR.
There was a problem hiding this comment.
@samay-rgb @PranshuNayak PTAL.
PranshuNayak
dismissed
their stale review
Remove the pushed migrations from schloarship module.
divyanshkhetan
force-pushed
the
ambulance
branch
from
9fe57f0 to
9b3190d
Compare
samay-rgb
approved these changes
Apr 16, 2023
akshatnema
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots