OS-2 : Week - 4 : Prescription in appointment history and emergency contact number in doctor's schedule #1077
Conversation
divyanshkhetan
changed the title
divyanshkhetan
changed the title
divyanshkhetan
changed the title
|
@divyanshkhetan Kindly push the migrations of this PR as there is a change in models.py. Review required from @PranshuNayak and @samay-rgb. |
|
@divyanshkhetan Also, resolve the merge conflicts in the PR. |
| doctor_phone = models.CharField(max_length=10) | ||
| specialization = models.CharField(max_length=100) | ||
| active = models.BooleanField(default=True) | ||
| contact_no = models.IntegerField(default=0) |
There was a problem hiding this comment.
use a Charfield instead and keep a max_length and min_length 10
|
@PranshuNayak @samay-rgb please take a look. |
| doctor_phone = models.CharField(max_length=10) | ||
| specialization = models.CharField(max_length=100) | ||
| active = models.BooleanField(default=True) | ||
| contact_no = models.CharField(max_length=10, validators=[MinLengthValidator(10)], default=0000000000) |
There was a problem hiding this comment.
The default must be a string for a CharField. Use min_length=10 instead of the validator.
There was a problem hiding this comment.
@PranshuNayak
That is used for forms.CharField() and not for models.CharField(). That is why I used a validator.
There was a problem hiding this comment.
you need to change the default , it must be string
There was a problem hiding this comment.
Migration file should be updated too.
There was a problem hiding this comment.
@divyanshkhetan push new migrations, since you have changed the default value for contact_no
|
@PranshuNayak done. |
5 participants
Proposed changes
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots'