Ui Changes and Added functionality of designation #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@varun7singh |
Contributor
Author
|
Updated sidebar , app bar , dashboard ,added functionality of selecting multiple designation through dropdown in appBar |
Contributor
Author
Contributor
Author
Shivkant-Chauhan
suggested changes
Apr 11, 2024
Contributor
Shivkant-Chauhan
left a comment
Shivkant-Chauhan
left a comment
There was a problem hiding this comment.
Unable to review fully, GitHub leads will take care of it
| @@ -1,12 +1,12 @@ | |||
| buildscript { | |||
| ext.kotlin_version = '1.6.10' | |||
| ext.kotlin_version = '1.8.21' | |||
Contributor
There was a problem hiding this comment.
did you confirm this changing of kotlin version with the Android leads (Priyanshu or Pranjal)
android/build.gradle
Outdated
|
|
||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:4.2.2' | ||
| classpath 'com.android.tools.build:gradle:7.3.0' |
Contributor
Author
There was a problem hiding this comment.
We have updated the gradle version after confirming leads to 7.4.2
Contributor
|
LGTM. Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.