Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mcr/dotnet web quickstart #2410

Merged
merged 22 commits into from
Sep 21, 2023
Merged

Mcr/dotnet web quickstart #2410

merged 22 commits into from
Sep 21, 2023

Conversation

mark-robustelli
Copy link
Contributor

@mark-robustelli mark-robustelli commented Aug 7, 2023

Moving to Astro, please run through quickstart and let me know if there is anything I can make more clear.


@mooreds
Copy link
Contributor

mooreds commented Aug 7, 2023

@mark-robustelli I'd like to review this after Matt takes a look, just to check for consistency.

@mark-robustelli mark-robustelli removed the request for review from matt1hathcock August 17, 2023 20:11
Copy link
Contributor

@alex-fusionauth alex-fusionauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple changes

astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
@alex-fusionauth
Copy link
Contributor

This looks good to me, I would have @mooreds do a final :D

@alex-fusionauth alex-fusionauth requested review from mooreds and removed request for alex-fusionauth August 21, 2023 14:53
Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Biggest issue is the blowing away of the complete_application directory. Would love to hear ideas that allow:

  • the user to review or run complete_application when they want to as they build out the new application
  • still let you pull the code from the remote repo.

astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
@mark-robustelli
Copy link
Contributor Author

I have made the required changes. Would like to talk about the frontmatter section if you are interested.

@mooreds mooreds self-requested a review August 29, 2023 16:07
Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few smaller changes.

astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
@mooreds
Copy link
Contributor

mooreds commented Aug 29, 2023

One more comment. I modified the video we were linking to in this PR: #2487 Please use the new one.

@mark-robustelli
Copy link
Contributor Author

mark-robustelli commented Sep 6, 2023

One more comment. I modified the video we were linking to in this PR: #2487 Please use the new one.

Video updated

@mark-robustelli
Copy link
Contributor Author

@mooreds I think we are finally good to go here. Please let me know.

@mark-robustelli mark-robustelli added content Alert marketing to this change devrel labels Sep 6, 2023
Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes. No need for me to review after you make them, send it on to SEO review.

astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
astro/src/content/quickstarts/quickstart-dotnet-web.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@bradmccarty bradmccarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mooreds
Copy link
Contributor

mooreds commented Sep 20, 2023

Can you publish this, @mark-robustelli ?

@mark-robustelli mark-robustelli merged commit 9ef2d8c into master Sep 21, 2023
2 checks passed
@mark-robustelli mark-robustelli deleted the mcr/dotnet-web-quickstart branch September 21, 2023 22:34
@mooreds
Copy link
Contributor

mooreds commented Sep 21, 2023

🎉 🎉 🎉 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Alert marketing to this change devrel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants