-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mcr/dotnet web quickstart #2410
Conversation
@mark-robustelli I'd like to review this after Matt takes a look, just to check for consistency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple changes
This looks good to me, I would have @mooreds do a final :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Biggest issue is the blowing away of the complete_application directory. Would love to hear ideas that allow:
- the user to review or run complete_application when they want to as they build out the new application
- still let you pull the code from the remote repo.
I have made the required changes. Would like to talk about the frontmatter section if you are interested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few smaller changes.
- https://github.com/FusionAuth/fusionauth-quickstart-dotnet-web should use
.NET
instead of.Net
- Let's talk through the archival process of the old .NET example apps.
- Quickstart github repo is smooth sailing!
One more comment. I modified the video we were linking to in this PR: #2487 Please use the new one. |
Video updated |
@mooreds I think we are finally good to go here. Please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes. No need for me to review after you make them, send it on to SEO review.
Co-authored-by: Dan Moore <[email protected]>
Co-authored-by: Dan Moore <[email protected]>
Co-authored-by: Dan Moore <[email protected]>
…ionauth-site into mcr/dotnet-web-quickstart
Co-authored-by: Dan Moore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you publish this, @mark-robustelli ? |
🎉 🎉 🎉 ! |
Moving to Astro, please run through quickstart and let me know if there is anything I can make more clear.