DO NOT MERGE - Bring Stripe Connect tweaks in from 2-0-stable-stripe #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so application_fee refunds can occur
glongman
changed the title
remove attr_accessible from StripeGateway
Removed referenced issue as it was implemented upstream.
Populating credit card fields from activemerchant response
- Using an environment variable to access the publishable key - Using different jQuery anchors
- Using an environment variable to access the publishable key - Using different jQuery anchors
Spree admin stripejs
Patient checkout stripejs
StripeJS support for Spree admin and patient checkout
The click handler from Spree didn't handle the case if "New Payment" wasn't selected. Now the click handler will do a plain submit on the form if anything else is selected.
Ensure application_fee ends up in the purchase options
|
Is the intention that we port this into 2-2-stable and then rebase our branch 2-2-stable-healthwave off of it? |
kurtfunai
reviewed
Dec 12, 2016
| @@ -73,8 +86,11 @@ def options | |||
|
|
|||
| def options_for_purchase_or_auth(money, creditcard, gateway_options) | |||
| options = {} | |||
| options[:description] = "Spree Order ID: #{gateway_options[:order_id]}" | |||
| options[:description] = "HealthWave Order: #{gateway_options[:order_id]}" | |||
There was a problem hiding this comment.
whoa - fyi - this PR predates the work Uri did bringing in tokens.
…der instead of HealthWave Order
Transaction description to read Fullscript instead of HealthWave Order
…-version Pass through specific stripe api version to activemerchant gem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.